dan/souplesse
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fail tests if empty points array

Browse Source 
tests were passing despite incomplete pattern matches, oops
This commit is contained in:
Daniel Barlow 2024-10-30 13:29:36 +00:00
parent 3192577d15
commit 90101760a2
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/UnitTest.hs
View File

@ -26,7 +26,7 @@ test1 = TestCase $
testMalformed = TestCase $ testMalformed = TestCase $
case Track.parse "<gpx><dgdsfg>></gpx>" of case Track.parse "<gpx><dgdsfg>></gpx>" of
Left err -> assertBool "syntax error" True Left err -> assertBool "syntax error" True
Right t -> assertFailure "no error message parsing bad xml" Right _ -> assertFailure "no error message parsing bad xml"
test2 = TestCase $ test2 = TestCase $
case Track.parse onepoint case Track.parse onepoint
@ -36,6 +36,7 @@ test2 = TestCase $
assertEqual "matches lat/lon" assertEqual "matches lat/lon"
(Track.Pos 51.0 (-0.1)) (Track.Pos 51.0 (-0.1))
(Track.pos p) (Track.pos p)
Right [] -> assertFailure "no points"
test3 = TestCase $ test3 = TestCase $
case Track.parse onepoint case Track.parse onepoint
@ -44,6 +45,7 @@ test3 = TestCase $
Right (p:ps) -> Right (p:ps) ->
assertEqual "matches elevation" assertEqual "matches elevation"
Nothing (Track.elevation p) Nothing (Track.elevation p)
Right [] -> assertFailure "no points"
test4 = TestCase $ test4 = TestCase $
case Track.parse onepointEle case Track.parse onepointEle
@ -52,6 +54,7 @@ test4 = TestCase $
Right (p:ps) -> Right (p:ps) ->
assertEqual "matches elevation" assertEqual "matches elevation"
(Just 25.2) (Track.elevation p) (Just 25.2) (Track.elevation p)
Right [] -> assertFailure "no points"
tests :: Test tests :: Test
tests = TestList [ tests = TestList [