commit 9e042bd385da157a0e6d1656e01588ffc458ca8c
parent 26e1608fa7da7617751ea0407fa11f547245ed92
Author: Daniel Barlow <dan@telent.net>
Date: Mon, 27 Oct 2025 21:12:06 +0000
ppp: ignore error return from writing readiness notification
ip-up and ipv6-up both attempt to write to fd 10, but only the
first writer will succeed because the peer closes the pipe as soon
as it gets anything. I can't see a way to make this race-proof, so
... here we are
Diffstat:
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/modules/ppp/common.nix b/modules/ppp/common.nix
@@ -41,7 +41,7 @@ let
if test -n "''${DNS1}" ;then echo ''${DNS1} > ns1 ; fi
if test -n "''${DNS2}" ;then echo ''${DNS2} > ns2 ; fi
touch ip-up
- test -e ipv6-up && echo >/proc/self/fd/10
+ test -e ipv6-up && ( echo >/proc/self/fd/10 || true)
'';
ip6-up = writeAshScript "ip6-up" { } ''
exec >&5 2>&5
@@ -50,7 +50,7 @@ let
echo $5 > ipv6-peer-address
echo $4 > ipv6-address
touch ipv6-up
- test -e ip-up && echo >/proc/self/fd/10
+ test -e ip-up && ( echo >/proc/self/fd/10 || true)
'';
literal_or_output =
let