dan
/
liminix
1
0
Fork 5
Code Issues 2 Pull Requests 1 Projects Releases Wiki Activity

Add support for TP-Link Archer AX23 #6

Merged
dan merged 2 commits from raboof/liminix:add-archer-ax23-v1-bak into main 2024-02-08 17:47:47 +00:00
Conversation 0 Commits 2 Files Changed 6 +528 -1
raboof commented 2024-01-30 10:29:29 +00:00
Contributor
Copy Link
No description provided.
raboof changed title from add-archer-ax23-v1-bak to Add support for TP-Link Archer AX23 2024-01-30 10:30:25 +00:00
dan reviewed 2024-02-01 10:11:09 +00:00
dan left a comment
Owner
Copy Link

This is great. I have a few small comments, but overall I'd love to have this merged.

Can you also add it to devices in ci.nix? I can't test it boots as I don't have the hardware, but we can at least have it built on build.liminix.org

This is great. I have a few small comments, but overall I'd love to have this merged. Can you also add it to `devices` in `ci.nix`? I can't test it boots as I don't have the hardware, but we can at least have it built on build.liminix.org
devices/tp-archer-ax23/default.nix Outdated
@ -0,0 +320,4 @@
ZLIB_DEFLATE="y";
ZLIB_INFLATE="y";
ZSTD_COMPRESS="y";
ZSTD_DECOMPRESS="y";
dan commented 2024-02-01 09:57:04 +00:00
Owner
Copy Link

There's quite a lot in here and I wonder if it could be made shorter with make savedefconfig to remove any symbols that are only listed because they're selected by other symbols

(I haven't tried it. Maybe there aren't ...)

There's quite a lot in here and I wonder if it could be made shorter with `make savedefconfig` to remove any symbols that are only listed because they're selected by other symbols (I haven't tried it. Maybe there aren't ...)
raboof commented 2024-02-06 22:30:26 +00:00
Author
Contributor
Copy Link

I agree it's quite a lot - but make savedefconfig gives me an output with even more (800+ configuration options)... I'm open to suggestions on how to make this better ;)

I agree it's quite a lot - but `make savedefconfig` gives me an output with even more (800+ configuration options)... I'm open to suggestions on how to make this better ;)
devices/tp-archer-ax23/default.nix Outdated
@ -0,0 +333,4 @@
# IP addresses to use in the boot monitor when flashing/ booting
# over TFTP. If you are flashing using the stock firmware's Web UI
# then these dummy values are fine
ipaddr = "192.168.0.1"; # router address
dan commented 2024-02-01 09:59:32 +00:00
Owner
Copy Link

ipaddr and serverip are almost certainly local config not per-device config so shouldn't be declared here (same is true if there are.other files in devices/ that set these). If tftpboot doesn't work on this device anyway, I'd be inclined to take out the entire tftp stanza

`ipaddr` and `serverip` are almost certainly local config not per-device config so shouldn't be declared here (same is true if there are.other files in devices/ that set these). If tftpboot doesn't work on this device anyway, I'd be inclined to take out the entire `tftp` stanza
raboof marked this conversation as resolved
devices/tp-archer-ax23/default.nix Outdated
@ -0,0 +398,4 @@
# 0x000000040000-0x000000fa0000
size = lim.parseInt "0xf60000";
# guessed:
eraseBlockSize = 65536;
dan commented 2024-02-01 10:00:52 +00:00
Owner
Copy Link

You can get the eraseSize from /proc/mtd on a running system

You can get the `eraseSize` from `/proc/mtd` on a running system
modules/outputs/tplink.nix Outdated
@ -0,0 +16,4 @@
};
options.system.outputs = {
tplink = mkOption {
type = types.package;
dan commented 2024-02-01 10:05:54 +00:00
Owner
Copy Link

nit: maybe this could be called tplink-safeloader instead of just tplink. Much more googleable for someone with one of these devices who doesn't have the background knowledge yet

nit: maybe this could be called `tplink-safeloader` instead of just `tplink`. Much more googleable for someone with one of these devices who doesn't have the background knowledge yet
raboof marked this conversation as resolved
dan added the
hardware
 label 2024-02-05 10:48:06 +00:00
raboof force-pushed add-archer-ax23-v1-bak from 60696dd8a2 to 63e3f2aa58 2024-02-06 22:28:29 +00:00 Compare
raboof requested review from dan 2024-02-06 22:32:34 +00:00
dan merged commit 273c66b2d3 into main 2024-02-08 17:47:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dan
Labels
Clear labels   
bug

Something is not working

  
bugfix

This PR fixes a bug

  
doc

This PR improves documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
hardware

This PR adds or enhances support for a hardware device

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
bugfix
doc
duplicate
enhancement
hardware
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: dan/liminix#6
No description provided.
Delete Branch "raboof/liminix:add-archer-ax23-v1-bak"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?